Move to streams #10
Merged
Move to streams #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jettify
force-pushed
the
move-to-streams
branch
from
1bcdd5e
to
8c33c50
Compare
|
|
||
| def connection_lost(self, exc): | ||
| pass |
There was a problem hiding this comment.
How it signals to user-level API about transport errors?
There was a problem hiding this comment.
I guess that supposed to be implemented later, signaling via some sort of Future object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed
AsyncioMotorSocket, so now it relies onStreamReaderandStreamWriterinterface instead implementingasyncio.Protocol. This simplifies code, what do you think?