Skip to content

Commit

Permalink
fix(NODE-3986): unskip MONGODB-AWS test (#3397)
Browse files Browse the repository at this point in the history
  • Loading branch information
biniona-mongodb committed Sep 8, 2022
1 parent 0a2ad07 commit 5676f81
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
13 changes: 12 additions & 1 deletion src/connection_string.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ import { MongoCredentials } from './cmap/auth/mongo_credentials';
import { AUTH_MECHS_AUTH_SRC_EXTERNAL, AuthMechanism } from './cmap/auth/providers';
import { Compressor, CompressorName } from './cmap/wire_protocol/compression';
import { Encrypter } from './encrypter';
import { MongoAPIError, MongoInvalidArgumentError, MongoParseError } from './error';
import {
MongoAPIError,
MongoInvalidArgumentError,
MongoMissingCredentialsError,
MongoParseError
} from './error';
import { Logger, LoggerLevel } from './logger';
import {
DriverInfo,
Expand Down Expand Up @@ -407,6 +412,12 @@ export function parseOptions(
});
}

if (isAws && mongoOptions.credentials.username && !mongoOptions.credentials.password) {
throw new MongoMissingCredentialsError(
`When using ${mongoOptions.credentials.mechanism} password must be set when a username is specified`
);
}

mongoOptions.credentials.validate();

// Check if the only auth related option provided was authSource, if so we can remove credentials
Expand Down
6 changes: 0 additions & 6 deletions test/unit/assorted/auth.spec.test.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
import { loadSpecTests } from '../../spec';
import { executeUriValidationTest } from '../../tools/uri_spec_runner';

const SKIP = ['should throw an exception if username and no password (MONGODB-AWS)'];

describe('Auth option spec tests', function () {
const suites = loadSpecTests('auth');

for (const suite of suites) {
describe(suite.name, function () {
for (const test of suite.tests) {
it(`${test.description}`, function () {
if (SKIP.includes(test.description)) {
this.test.skipReason = 'NODE-3986: Fix MONGODB-AWS Spec Test';
this.skip();
}
executeUriValidationTest(test);
});
}
Expand Down

0 comments on commit 5676f81

Please sign in to comment.