url_parser that treats an empty tag set as null, not [].

mongodb · Nov 20, 2012 · 87fa2b2 · 87fa2b2
1 parent 49b6157
commit 87fa2b2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/mongodb/connection/url_parser.js b/lib/mongodb/connection/url_parser.js
@@ -206,6 +206,11 @@ exports.parse = function(url, options) {
     }
   });
 
+  // No tags: should be null (not [])
+  if(dbOptions.read_preference_tags.length === 0) {
+    dbOptions.read_preference_tags = null;
+  }
+
   // Validate if there are an invalid write concern combinations
   if((dbOptions.w == -1 || dbOptions.w == 0) && (
       dbOptions.journal == true
@@ -219,4 +224,4 @@ exports.parse = function(url, options) {
   object.servers = servers;
   // Returned parsed object
   return object;
-}
+}
diff --git a/test/url_parser_test.js b/test/url_parser_test.js
@@ -371,6 +371,9 @@ exports['Read preferences parsing'] = function(test) {
  * @ignore
  */
 exports['Read preferences tag parsing'] = function(test) {
+  var object = parse("mongodb://localhost/db");
+  test.equal(null, object.db_options.read_preference_tags);
+
   var object = parse("mongodb://localhost/db?readPreferenceTags=dc:ny");
   test.deepEqual([{dc:"ny"}], object.db_options.read_preference_tags);