Collection method "Group" no longer wrecks the "keys" argument when it is a function #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
now that's more like it :) I wish all pull request came like this :) |
christkv
added a commit
that referenced
this pull request
Jun 3, 2011
Collection method "Group" no longer wrecks the "keys" argument when it is a function
|
My pleasure. I depend on this particular functionality for my project and it is definitely in my interest to see quick approval of my pull requests so I don't have to hassle with maintaining a multitude of forks. Thank YOU! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion of the function to an array previously prevented grouping with a function to work. Also added corresponding test case and fixed a spelling error in the test runner.