feat: remove top-level write concern options #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanaPearlman
changed the title
nbbeeken
force-pushed
the
NODE-1722/master/deprecate-wc-options
branch
from
ed0868f
to
b4346bb
Compare
emadum
approved these changes
Dec 3, 2020
src/operations/connect.ts
Outdated
| } | ||
|
|
||
| if (connStrOptions.srvHost) { | ||
| connStrOpts.srvHost = connStrOptions.srvHost; | ||
| } | ||
|
|
||
| // Any write concern options from the URL will be top-level, so we manually | ||
| // move them options under `object.writeConcern` | ||
| const wcKeys = ['w', 'wtimeout', 'j', 'journal', 'fsync']; |
There was a problem hiding this comment.
I'd prefer to see this in a const exported by write_concern.ts, to make future maintenance easier. Perhaps we can restore the export of writeConcernKeys that was deleted and add the missing journal key in?
nbbeeken
force-pushed
the
NODE-1722/master/deprecate-wc-options
branch
2 times, most recently
from
5d2b9aa
to
7e543c4
Compare
nbbeeken
force-pushed
the
NODE-1722/master/deprecate-wc-options
branch
from
7e543c4
to
e1246db
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code changes include: the
WriteConcerntype now has only one property:writeConcern: WriteConcern | WriteConcernSettings, whereWriteConcernSettings(naming up for debate) encompasses the old top-level options.WriteConcern.fromOptionsignores the old top-level WC options.The change to
legalOptionNamesindb.tsmeans the old top-level WC options will be filtered out when creating aDb. The change tovalidOptionNamesinoperations/connect.tsmeans it will either error or warn (configurable) if the old top-level WC options are passed to aMongoClient.Test changes include everything from #2624 and now all options that are not being used to create a connection string use the
writeConcernkey.NODE-1722