fix(NODE-3263): force closing a pool closes active connections #2804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR using
MongoClient.close(true)
to force-close the client did also trigger a force-close of the connection pool and the individual connections. However, as the pool only tracked available connections (not all connections that were created by the pool), it could not close connections that were active.This fix PR adds:
Set
.The behavior and semantics of the
MongoClient.close()
(i.e. withoutforce = true
) remain unchanged.The test case will fail when the iteration in line 342 is made only over the available connections.