Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmap): undo flipping of beforeHandshake flag for timeout errors #2813

Merged
merged 3 commits into from
May 21, 2021
Merged

fix(cmap): undo flipping of beforeHandshake flag for timeout errors #2813

merged 3 commits into from
May 21, 2021

Commits on May 20, 2021

  1. fix(cmap): undo flipping of beforeHandshake flag for timeout errors

    @vkarpov15
    vkarpov15 authored May 20, 2021
    Configuration menu
    Copy the full SHA
    044800b View commit details
    Browse the repository at this point in the history

  2. fix: always define kBeforeHandshake symbol on MongoNetworkError 

    Add a unit test to confirm this behavior doesn't regress
    @nbbeeken
    nbbeeken committed May 20, 2021
    Configuration menu
    Copy the full SHA
    20ef2f5 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. fix: make timeout handler use getter 

    - only define before handshake symbol if correct option is passed
- clean up chai usage
- rename tests
- add tests for symbol defining
    @nbbeeken
    nbbeeken committed May 21, 2021
    Configuration menu
    Copy the full SHA
    70ff3fb View commit details
    Browse the repository at this point in the history