Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-1502): Command monitoring commands should be copies #2832

Merged
merged 16 commits into from Jun 14, 2021
Merged

fix(NODE-1502): Command monitoring commands should be copies #2832

merged 16 commits into from Jun 14, 2021

Commits on Jun 11, 2021

  1. stared fix for NODE-1502

    @W-A-James
    Warren James authored and W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    e5d4366 View commit details
    Browse the repository at this point in the history

  2. finished NODE-1502

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    5addcc6 View commit details
    Browse the repository at this point in the history

  3. Fixed formatting

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    103b3d5 View commit details
    Browse the repository at this point in the history

  4. Changed scope of clonedCommand variable

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    88f30b4 View commit details
    Browse the repository at this point in the history

  5. Added test to ensure that copying commands for command monitoring wor… 

    …ks as expected
    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    61328bf View commit details
    Browse the repository at this point in the history

  6. Made deep copies of command fields when extracting commands in src/cm… 

    …ap/command_monitoring_events.ts
    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    c950d95 View commit details
    Browse the repository at this point in the history

  7. Reverted changes to src/cmap/connection.ts

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8164edd View commit details
    Browse the repository at this point in the history

  8. Made test for NODE-1502 account for nested documents

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    85eb06a View commit details
    Browse the repository at this point in the history

  9. Added test metadata to ensure test only runs on mongodb versions >=3.6.0

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    0761b5e View commit details
    Browse the repository at this point in the history

  10. fixed bug extractCommand in src/cmap/command_monitoring_events.ts

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    2a33218 View commit details
    Browse the repository at this point in the history

  11. Removed unused import

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    dcdecb1 View commit details
    Browse the repository at this point in the history

  12. Resolved review comments

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    59a3e73 View commit details
    Browse the repository at this point in the history

  13. Cleaning up after test

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    a124325 View commit details
    Browse the repository at this point in the history

  14. Added unit test to ensure the CommandStartedEvents do not hold refere… 

    …nces to commands passed into the constructor
    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    4560e9d View commit details
    Browse the repository at this point in the history

  15. fix: removed unneeded boilerplate from test

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    7fe8818 View commit details
    Browse the repository at this point in the history

  16. fix: removed done callback and changed forEach to for of loop

    @W-A-James
    W-A-James committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    b6c58ae View commit details
    Browse the repository at this point in the history