fix(NODE-1502): Command monitoring commands should be copies #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
suggested changes
Jun 10, 2021
nbbeeken
reviewed
Jun 10, 2021
nbbeeken
suggested changes
Jun 10, 2021
nbbeeken
suggested changes
Jun 11, 2021
…ap/command_monitoring_events.ts
…nces to commands passed into the constructor
W-A-James
force-pushed
the
NODE-1502/4.0/Command-monitoring-commands-should-be-copies
branch
from
1616ec2 to
b6c58ae
Compare
durran
approved these changes
Jun 12, 2021
dariakp
approved these changes
Jun 14, 2021
nbbeeken
deleted the
NODE-1502/4.0/Command-monitoring-commands-should-be-copies
branch
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed events for Command monitoring to hold copies of the commands instead of the commands themselves to prevent changing state in event monitoring by modifying
extractCommandfunction in src/cmap/command_monitoring_events.tsWhat changed?