Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-4774): deprecate cursor forEach #3622

Merged
merged 2 commits into from
Apr 5, 2023
Merged

feat(NODE-4774): deprecate cursor forEach #3622

merged 2 commits into from
Apr 5, 2023

Conversation

durran
Copy link
Member

@durran durran commented Apr 4, 2023

Description

Deprecates AbstractCursor.forEach()

What is changing?

Deprecates the method in favour of for await...of.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4774

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

addaleax
addaleax previously approved these changes Apr 4, 2023
@W-A-James W-A-James self-assigned this Apr 4, 2023
@W-A-James W-A-James self-requested a review April 4, 2023 14:26
W-A-James
W-A-James previously approved these changes Apr 4, 2023
@W-A-James W-A-James added the Team Review Needs review from team label Apr 4, 2023
@nbbeeken nbbeeken self-requested a review April 4, 2023 15:55
nbbeeken
nbbeeken previously approved these changes Apr 4, 2023
@W-A-James W-A-James merged commit 8d76a71 into main Apr 5, 2023
@W-A-James W-A-James deleted the NODE-4774 branch April 5, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants