test(NODE-5265): fix flaky operation count test #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
changed the title
baileympearson
requested changes
May 30, 2023
Comment on lines
+427
to
+436
| private decrementOperationCount(): number { | ||
| return (this.s.operationCount -= 1); | ||
| } | ||
|
|
||
| /** | ||
| * Increment the operation count, returning the new count. | ||
| */ | ||
| private incrementOperationCount(): number { | ||
| return (this.s.operationCount += 1); | ||
| } |
There was a problem hiding this comment.
Any reason to return the new count, if we're not chaining it or using the returned value?
There was a problem hiding this comment.
No was just a general practice I like to use - if the method would normally be void try potentially returning something useful if possible.
baileympearson
added
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes operation count flaky test.
What is changing?
Wraps the increment/decrement of the server's operation count in 2 methods, that then can be spied on to assert the number of times each was called.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5265
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript