Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed PropType warning in DocumentBody #152

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Fix failed PropType warning in DocumentBody #152

merged 1 commit into from
Feb 4, 2020

Conversation

nlarew
Copy link
Contributor

@nlarew nlarew commented Feb 4, 2020

Switches PropTypes.oneOf to PropTypes.oneOfType.

See https://jaketrent.com/post/react-oneof-vs-oneoftype/ for details

image

@nlarew nlarew requested a review from sophstad February 4, 2020 00:57
@sophstad sophstad merged commit a655dbb into master Feb 4, 2020
@sophstad sophstad deleted the proptypes branch February 4, 2020 01:00
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
@nlarew
Fix failed PropType warning in DocumentBody (#152)
b47f8bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophstad sophstad sophstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlarew @sophstad