Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-980: Refactor feedback widget #191

Merged
merged 4 commits into from
May 13, 2020
Merged

DOP-980: Refactor feedback widget #191

merged 4 commits into from
May 13, 2020

Conversation

sophstad
Copy link
Member

@sophstad sophstad commented May 12, 2020 •
edited
Loading

[JIRA] [Guides Staging] [Drivers Staging] [BI Connector Staging]

  • Move FeedbackWidget/ directory into Widgets/ directory
  • Render feedback widget in DefaultLayout component so that it will render in all template types
  • Fix overlap problem involving code blocks and the feedback widget and its tooltips

danielborowski
danielborowski approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@danielborowski danielborowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

mango-db
mango-db approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@mango-db mango-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spawned Feedback widget fails with Ghostery / Ka-block!. Otherwise, LGTM.

@sophstad sophstad merged commit 64090c2 into master May 13, 2020
@sophstad sophstad deleted the DOP-980 branch May 13, 2020 15:29
@sophstad sophstad mentioned this pull request May 13, 2020
Closed
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
@sophstad
DOP-980: Refactor feedback widget (#191)
80a4c9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielborowski danielborowski danielborowski approved these changes

@mango-db mango-db mango-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophstad @danielborowski @mango-db