Add Searchbar and Search Results Page to Snooty #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add leafygreen text input * Build general searchbar structure * Fix blur animation issue * Clean up CSS * Switch Navbar to Function Component * Bump leafy text box to 3.0.0 * Clean up theme values, colors, self-closing div * Remove extraneous style and update snapshot * Implement basic expansion animation for mobile * WIP move control to parent * WIP add mobile support * Add screen-reader labels * Clean up common button styling * Remove ref experiment * Clean up animation timing, more css cleanup * Fix go button, add commentary * Dont opaque navbar on mobile since it is covered * WIP mobile * Clean up mobile top issue and change hover state * Remove type search due to issues * Fix bad navbar merge * Add position and color feedback from Allison * Add additional breakpoints to expand/collapse searchbar * Remove hover handlers and use emotion to handle focus, hover events * Add useMedia hook to re-run on mount * Fix SSR issues using the isClient/useEffect pattern * Use isBrowser helper and use query from theme
* Add general pagination component * Fix onClick position, add thorough tests * Clean up alignment and sizing * Remove old comment * Swap to using leafy icon button * Remove code no longer needed with icon button
* Fetch from marian and display * Fix pagination merge, move prop spread on result * Clean up hover state * Add height 100% to div * Rename local const to avoid confusion * Clean up fonts * Clean up click outside handling with hook * Use a nicer escape * Use arrow fns * Lighten hover color and activate on tab
* Abstract marian result parsing out of searchbar * Update navbar, searchbar, pagination snapshots * Add param to optionally return some number of results with test * Standardize on JSON
* Add safe search highlighting * Clean up tag close
* Add safe search highlighting * WIP * WIP * WIP * WIP * Clean up mobile active state * Update snapshots for context provider * Clean up css and use docsTheme font size * Swap mobile size to Small, remove 100% always height on mobile * Clean up blur bog on iOS * Cleanup changes for brevity * Fix url prop * Always fill in mobile text bar
* Split large searchbar component into proper hierarchy * Clean up * Clean up icon button and search text
* Parse and Format Marian Manifests * Use regex to parse manifest, add rest of manifests to mapping * Add comment for regex * Split logic for parsing one marian manifest * Update label names
* Add basic filter UI (non-functional) * Fix styling changes * Add unused reset button for footer
* Add basic filter UI (non-functional) * Fix styling changes * Add unused reset button for footer * Implement filter logic * Use marian PROD * Use draft state prop * Push logic into context * Clean up hooks * Clean up hooks in top level * Add empty state * Update search filter comment * Sort properties case insensitive * Rename current/master to stable/latest
…254) * Add search query instrumentation * Add search rank instrumentation * Fix docs tools * Fix docs tools again
* Add basic filter UI (non-functional) * Fix styling changes * Add unused reset button for footer * Implement filter logic * Use marian PROD * Use draft state prop * Push logic into context * Clean up hooks * Clean up hooks in top level * Add empty state * Update search filter comment * Sort properties case insensitive * Address dupe key issue * Add button hover * Add y offset for box shadow * Make pagination botton hover a perfect circle * Rename current/master to stable/latest * Fix spacing
* Parse the search-results directive * Add basic filter UI (non-functional) * Fix styling changes * Add unused reset button for footer * Implement filter logic * Use marian PROD * Use draft state prop * Push logic into context * Clean up hooks * Clean up hooks in top level * Add empty state * Update search filter comment * Sort properties case insensitive * WIP search page * WIP testing * Clean up testing * Add support for large title via prop * Add bold for title when enabled * Rename current/master to stable/latest * Update filter test for Latest replacement * Remove tests for other PR * Remove snapshot * Fix search URLs * DOP-1371: Add 'blank-wide' template * Add conent sub-wrapper * Reorder css * Add page title * Refactor into subdir, add instrumentation * Add areaFrom to existing instrumentation * Remove empty state for now * Remove empty state for now * Clean up empty state for now * Remove extra ) * Add enter key functionality * Remove fragment
* Add onClick for magnifying glasses * Safe dom search, reorder CSS
* Add more significant testing * Address warnings * Clean up query param and update searchbar snapshot * Update snapshot for empty state addition
|
This is now ready to go! Feel free to merge in when the team is ready for this to go live |
sophstad
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Epic
InVision
Staging
Scope
This PR encompasses all of the previously approved work for the new search front-end.