DOP-1340 Part 1: Instrumentation for SearchQuery and SearchSelection #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
approved these changes
Aug 14, 2020
|
🤙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
Staging (Nothing super exciting)
Adding Elle so she can make sure the reporting structure is good.
This PR is the first of two parts (the second being focus/blur) of adding instrumentation for the search experience. Specifically we add two
reportAnalyticscalls that match a comment left in the ticket.SearchQuerytriggers anytime a search is sent to Marian and includes the query in the payloadSearchSelectiontriggers when an option is selected and reports both the overall rank of the item and the url.Here is a sample of this going through to Segment with the proper event name and payload (this example is for
SearchQuery, but you get the idea forSearchSelection. I pulled this from the network tab right off staging.