Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-1407: Populate page title on server #264

Merged
merged 1 commit into from
Aug 24, 2020
Merged

DOP-1407: Populate page title on server #264

merged 1 commit into from
Aug 24, 2020

Conversation

sophstad
Copy link
Member

@sophstad sophstad commented Aug 24, 2020 •
edited
Loading

[JIRA] [Datalake Staging] Populate <title> tag during Server-Side Rendering so that Marian can access it.

To test, open the staging link and view page source. You can see that the <title> tag is no longer empty. Here is a page with monospace in the title. In its source:

<title data-react-helmet="true">dropStore — MongoDB Atlas Data Lake</title>

@sophstad sophstad requested a review from i80and August 24, 2020 20:06
i80and
i80and approved these changes Aug 24, 2020
View reviewed changes
Copy link
Collaborator

@i80and i80and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sorcery to me. Is it worth adding an explanatory comment, or is this something that somebody familiar with gatsby should be able to reasonably deduce?

@sophstad sophstad merged commit 88f943f into master Aug 24, 2020
@sophstad sophstad deleted the DOP-1407 branch August 24, 2020 20:36
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
@sophstad
DOP-1407: Populate page title on server (#264)
67d5157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i80and i80and i80and approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophstad @i80and