DOP-1549: Fix version dropdown links #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmalliso
reviewed
Sep 22, 2020
| {active.map(version => { | ||
| const url = normalizePath(`${generatePrefix(version)}/${slug}`); | ||
| {Object.entries(gitNamedMapping).map(([branch, name]) => { | ||
| const url = normalizePath(`${generatePrefix(branch)}/${slug}`); |
There was a problem hiding this comment.
Is the branch and slug backwards?
The link is https://docs-mongodbcom-staging.corp.mongodb.com/19.12/charts/sophstad/master/ and I would have expected /charts/19.12/sophstad, but I also may be confused.
There was a problem hiding this comment.
This is indeed a matter of staging vs. production; for production builds, we use this logic:
if (pathPrefix) {
const [project] = pathPrefix.split('/');
return `/${project}/${version}`;
}But this led me to notice another bug that could result from PATH_PREFIX not including a preceding slash, so I fixed that and added a test to ensure we are generating the correct link!
schmalliso
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DOP-1549] [Charts Staging] [BI Connector Staging] Use values from the
git.branches.publishedtable of the published-branches.yaml file. These are the values that correspond to the git branches of each version, and also to the slug that should appear in the URL. Previously, the component was using the values that appear in theversion.activetable, which understandably worked out badly!