Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-1546: Upgrade LeafyGreen dependencies #289

Merged
merged 4 commits into from
Sep 29, 2020
Merged

DOP-1546: Upgrade LeafyGreen dependencies #289

merged 4 commits into from
Sep 29, 2020

Conversation

sophstad
Copy link
Member

@sophstad sophstad commented Sep 28, 2020 •
edited
Loading

[DOP-1546] [BI Connector Staging] [Drivers Staging]

  • Address breaking changes in LeafyGreen:
    • Remove variant prop
    • Rename ariaLabel to aria-label
    • Add baseFontSize to LeafyGreen Provider
    • Fix sizing of icon buttons used in search
  • Bonus:
    • Fix prop types warning in version dropdown
    • Improve getPathPrefix function
    • Add minor updates to other packages (npm update)

mango-db
mango-db approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@mango-db mango-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes all instances of ariaLabel to aria-label
  • Removes variant=dark and variant=light prop from ScreenshotButton, StarRating, CloseButton, in preparation for darkMode
  • Adds baseFontSize=16 to LeafyGreen Provider
  • Correct sizing of GoIcon buttons used in search
  • Fix prop types warning in VersionDropdown
  • Cleaner getPathPrefix function
  • Ran npm update for minor version updates
  • Staging LGTM

@sophstad sophstad merged commit 056efeb into master Sep 29, 2020
@sophstad sophstad deleted the DOP-1546 branch September 29, 2020 20:06
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
@sophstad
DOP-1546: Upgrade LeafyGreen dependencies (#289)
161c182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mango-db mango-db mango-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophstad @mango-db