DOP-1604: Allow code blocks to render with caption #299
Conversation
src/components/Code.js
Outdated
| font-weight: bold; | ||
| `} | ||
| > | ||
| {caption} |
There was a problem hiding this comment.
Just flagging: once this is implemented, we'll probably need to use a ComponentFactory here to render the caption.
src/components/Code.js
Outdated
| @@ -40,7 +40,7 @@ const getLanguage = lang => { | |||
| }; | |||
|
|
|||
| const Code = ({ | |||
| nodeData: { copyable, emphasize_lines: emphasizeLines, lang, linenos, value }, | |||
| nodeData: { copyable, caption, emphasize_lines: emphasizeLines, lang = 'none', linenos, value }, | |||
There was a problem hiding this comment.
Did you encounter a bug without this default none for lang? I recently changed this component to handle that in getLanguage(), so wondering if you're seeing something weird!
There was a problem hiding this comment.
Ah, my mistake! I accidentally left lang = 'none' because of a merge conflict. I'll fix this
src/components/Code.js
Outdated
| @@ -60,6 +60,17 @@ const Code = ({ | |||
| margin: ${theme.size.default} 0; | |||
| `} | |||
| > | |||
| {/* This implementation of caption should change with DOP-1639 */} | |||
| {caption && ( | |||
There was a problem hiding this comment.
The ticket was definitely unclear about this, but we actually want to render the caption as the component's chromeTitle, if it exists!
There was a problem hiding this comment.
Oh, gotcha. Will change
src/components/Code.js
Outdated
| @@ -72,6 +83,7 @@ const Code = ({ | |||
| highlightLines={emphasizeLines} | |||
| language={getLanguage(lang)} | |||
| showLineNumbers={linenos} | |||
| showWindowChrome={true} | |||
There was a problem hiding this comment.
We only want this property to be true if a caption is specified.
[DOP-1604]
[Realms Staging /android/mongodb]
This PR introduces the inclusion of captions to code blocks.
captionoptions are handled as strings. Code blocks now useshowWindowChrome.