Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-1014: Use LeafyGreen Tabs #316

Merged
merged 5 commits into from
Nov 9, 2020
Merged

DOP-1014: Use LeafyGreen Tabs #316

merged 5 commits into from
Nov 9, 2020

Conversation

sophstad
Copy link
Member

@sophstad sophstad commented Nov 6, 2020

[DOP-1014] [Datalake Staging] [Atlas Staging] Implementation details borrow from DevHub: mongodb/devhub#528

Note that the unexpected hover behavior (where the border does not become green after clicking) is a known limitation and a consequence of fixing a bug that Jordan explained here.

Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tabs look great. Just commented one miscellaneous question

src/components/Tabs.js Show resolved Hide resolved
@sophstad sophstad merged commit f92377e into master Nov 9, 2020
@sophstad sophstad deleted the DOP-1014 branch November 9, 2020 18:03
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants