Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-1789: Fix binary linking bug #329

Merged
merged 2 commits into from
Jan 5, 2021
Merged

DOP-1789: Fix binary linking bug #329

merged 2 commits into from
Jan 5, 2021

Conversation

sophstad
Copy link
Member

@sophstad sophstad commented Jan 5, 2021

[DOP-1789] [Database Tools Staging] [Manual Staging] docs-tools CSS applies display: none to binary targets, meaning that :binary: roles link to an ID that is not rendered on the page. This then triggers Gatsby's weird jumping behavior. So, render these targets as an empty span to ensure that :binary: anchor links work correctly.

Also update Gatsby!

@sophstad sophstad marked this pull request as ready for review January 5, 2021 19:07
@sophstad sophstad merged commit 9f4738e into master Jan 5, 2021
@sophstad sophstad deleted the DOP-1789 branch January 5, 2021 19:12
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants