SPEC-835: Clarify that percent signs must be encoded in userinfo #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Jan 9, 2017
| @@ -160,6 +160,14 @@ tests: | |||
| auth: ~ | |||
| options: ~ | |||
| - | |||
| description: "Username with password containing an unescaped percent sign" | |||
There was a problem hiding this comment.
If this is suitable, I will regenerate the JSON files before merging the PR.
jmikola
force-pushed
the
jmikola-spec835
branch
from
81b735f
to
644ce71
Compare
For a password that doesn't contain `@` or `:` but does contain `%40` there appears to be no way to determine if the password contains an `@` or the following 3 characters in sequence `%40`, unless we specify that `%` must be encoded.
jmikola
force-pushed
the
jmikola-spec835
branch
from
644ce71
to
2d434b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/SPEC-835
Supersedes #105.