INTMDB-828: [Terraform] Missing Schedule Parameter in Resource mongodbatlas_online_archive #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…batlas_online_archive
andreaangiolillo
changed the title
gssbzn
reviewed
Jul 3, 2023
gssbzn
approved these changes
Jul 3, 2023
Co-authored-by: Gustavo Bazan <gssbzn@gmail.com>
Zuhairahmed
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
LGTM pending doc update suggestions from @jwilliams-mongo, thanks @andreaangiolillo!
|
Hi @jwilliams-mongo, merging this PR as I addressed all your comments. I will open a follow-up PR to address any other comments if any. Thanks! |
X-Guardian
reviewed
Sep 8, 2023
| * `criteria.query` - JSON query to use to select documents for archiving. Atlas uses the specified query with the db.collection.find(query) command. The empty document {} to return all documents is not supported. | ||
| * `query` - JSON query to use to select documents for archiving. Atlas uses the specified query with the db.collection.find(query) command. The empty document {} to return all documents is not supported. | ||
|
|
||
| ### Schedule |
There was a problem hiding this comment.
schedule should have also been added to the Argument Reference section above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: INTMDB-828
This PR adds the schedule field to the
mongodbatlas_online_archiveresource and data sourceType of change:
Required Checklist:
Further comments
Running tool: /Users/andrea.angiolillo/.asdf/shims/go test -timeout 300000s -run ^TestAccBackupRSOnlineArchive$ github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas ok github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 1060.933s