Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove slack key from repo #1282

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Remove slack key from repo #1282

merged 2 commits into from
Jun 30, 2023

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Jun 30, 2023 •
edited
Loading

Description

Fix https://github.com/mongodb/terraform-provider-mongodbatlas/security/secret-scanning/1

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@maastha maastha marked this pull request as ready for review June 30, 2023 15:36
@maastha maastha requested a review from a team as a code owner June 30, 2023 15:36
gssbzn
gssbzn approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maastha maastha merged commit f588c42 into master Jun 30, 2023
18 checks passed
@maastha maastha deleted the remove-slack-key branch June 30, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@blva blva blva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maastha @gssbzn @blva