-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for project limits in project resource and project/projects data sources #1347
Conversation
… project/projects data sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! I left a few comments. Make sure to fix the lint error and to add an example under https://github.com/mongodb/terraform-provider-mongodbatlas/tree/master/examples
…mon method improving naming and adding documentation to method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments, not blocking. otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zach-carr any feedback on this one? if not @AgustinBettati feel free to merge in when ready |
Will go ahead and merge, if any comments are made I will make sure to address in a separate PR. |
diagWarning := diag.Diagnostic{ | ||
Severity: diag.Warning, | ||
Summary: "Error getting project's api keys", | ||
Detail: fmt.Sprintf("Error getting project's api keys (%s): %s", project.ID, err), | ||
} | ||
diags = append(diags, diagWarning) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems the root cause of the issue #1371
Description
Ticket: INTMDB-554
This PR includes the support for a new
limits
attribute in project resource and data source.Type of change:
Required Checklist:
Further comments