feat: support for project limits in project resource and project/projects data sources #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… project/projects data sources
AgustinBettati
commented
Jul 26, 2023
wtrocki
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Great work on this! I left a few comments. Make sure to fix the lint error and to add an example under https://github.com/mongodb/terraform-provider-mongodbatlas/tree/master/examples
gssbzn
reviewed
Jul 26, 2023
…mon method improving naming and adding documentation to method
Zuhairahmed
approved these changes
Jul 26, 2023
AgustinBettati
changed the title
|
@zach-carr any feedback on this one? if not @AgustinBettati feel free to merge in when ready |
|
Will go ahead and merge, if any comments are made I will make sure to address in a separate PR. |
Comment on lines
+217
to
+222
| diagWarning := diag.Diagnostic{ | ||
| Severity: diag.Warning, | ||
| Summary: "Error getting project's api keys", | ||
| Detail: fmt.Sprintf("Error getting project's api keys (%s): %s", project.ID, err), | ||
| } | ||
| diags = append(diags, diagWarning) |
There was a problem hiding this comment.
This change seems the root cause of the issue #1371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: INTMDB-554
This PR includes the support for a new
limitsattribute in project resource and data source.Type of change:
Required Checklist:
Further comments