doc: [Terraform] Create new example for BYOK and multi-region cluster #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,84 @@ | |||
| # Atlas Terraform Provider Example: Encryption at rest - AWS - Cluster | |||
There was a problem hiding this comment.
I moved the old example under the cluster folder and created the README.md
| @@ -0,0 +1,67 @@ | |||
| # Atlas Terraform Provider Example: Encryption at rest - AWS - Multi-Region Cluster | |||
There was a problem hiding this comment.
new example
Comment on lines
+1
to
+9
| module "multi-region-cluster" { | ||
| atlas_project_id = mongodbatlas_encryption_at_rest.test.project_id | ||
| provider_name = "AWS" | ||
| aws_region_shard_1 = var.aws_region_shard_1 | ||
| aws_region_shard_2 = var.aws_region_shard_2 | ||
| cluster_name = var.cluster_name | ||
| instance_size = "M10" | ||
| source = "./modules/multi-region-cluster" | ||
| } |
There was a problem hiding this comment.
the example uses a terraform module defined within the example
andreaangiolillo
changed the title
AgustinBettati
requested changes
Jul 27, 2023
examples/atlas-api-key/create-api-key-assign-to-multiple-projects/versions.tf
Show resolved
Hide resolved
AgustinBettati
approved these changes
Jul 27, 2023
Zuhairahmed
approved these changes
Jul 28, 2023
| @@ -181,7 +181,7 @@ resource "mongodbatlas_advanced_cluster" "cluster" { | |||
| node_count = 1 | |||
| } | |||
| provider_name = "GCP" | |||
| priority = 0 | |||
| priority = 5 | |||
There was a problem hiding this comment.
just curious, why are we changing advanced cluster priority in this doc example?
There was a problem hiding this comment.
sure, 0 is not a valid value for the priority. Getting this error
│ Error: error creating MongoDB ClusterAdvanced: POST https://cloud-dev.mongodb.com/api/atlas/v1.5/groups/63f4d4a47baeac59406dc131/clusters: 400 (request "INVALID_ATTRIBUTE") Invalid attribute electable region priority specified.
│
│ with mongodbatlas_advanced_cluster.cluster,
│ on main.tf line 1, in resource "mongodbatlas_advanced_cluster" "cluster":
│ 1: resource "mongodbatlas_advanced_cluster" "cluster" {
| @@ -181,7 +181,7 @@ resource "mongodbatlas_advanced_cluster" "cluster" { | |||
| node_count = 1 | |||
| } | |||
| provider_name = "GCP" | |||
| priority = 0 | |||
| priority = 5 | |||
| region_name = "US_EAST_4" | |||
There was a problem hiding this comment.
also can you confirm if we need to update priorities on cluster page as well? https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/cluster
There was a problem hiding this comment.
no, the examples have the correct priority
| @@ -48,7 +48,7 @@ resource "mongodbatlas_advanced_cluster" "test" { | |||
| node_count = 1 | |||
| } | |||
| provider_name = "AWS" | |||
| priority = 1 | |||
| priority = 7 | |||
There was a problem hiding this comment.
Error: error creating MongoDB ClusterAdvanced: POST https://cloud-dev.mongodb.com/api/atlas/v1.5/groups/63f4d4a47baeac59406dc131/clusters: 400 (request "ATLAS_GENERAL_ERROR") Reason: A replication spec must specify a region with priority 7.
│
│ with mongodbatlas_advanced_cluster.test,
│ on main.tf line 60, in resource "mongodbatlas_advanced_cluster" "test":
│ 60: resource "mongodbatlas_advanced_cluster" "test" {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new example of encryption at rest with a multi-region cluster defined as a terraform module.
Link to any related issue(s): INTMDB-340
Type of change:
Required Checklist:
Further comments