fix: Trigger resource force replacement when app id changes #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maastha
changed the title
|
@Zuhairahmed Please confirm if this needs a doc update as well. I didn't notice we mention about replacement in other resources. |
andreaangiolillo
approved these changes
Aug 15, 2023
Created docs ticket https://jira.mongodb.org/browse/DOCSP-32245 |
|
Thanks @maastha and @andreaangiolillo. I added in a simple commit for @zach-carr and team to build off if helpful. Otherwise LGTM |
Zuhairahmed
approved these changes
Aug 15, 2023
zach-carr
reviewed
Aug 18, 2023
| @@ -10,6 +10,8 @@ description: |- | |||
|
|
|||
| `mongodbatlas_event_trigger` provides a Event Trigger resource. | |||
|
|
|||
| Note: If the `app_id` changes in the mongodbatlas_event_trigger resource, it will force a replacement and delete itself from the old Atlas App Services app if it still exists then create itself in the new Atlas App Services app. See [Atlas Triggers](https://www.mongodb.com/docs/atlas/app-services/triggers/) to learn more. | |||
There was a problem hiding this comment.
Sorry about the late review - this looks good. My only suggestion is to add a comma right after "...if it still exists," to break up the sentence a little, but it's not an issue.
andreaangiolillo
pushed a commit
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue in #1310 and will enable deletion of trigger from existing app followed by creation of a new trigger in the new app on change of app_id attribute.
Link to any related issue(s): INTMDB-925
Type of change:
Required Checklist:
Further comments