Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disables event_trigger from acceptance test due to missing cluster. #1603

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

marcosuma
Copy link
Collaborator

Description

There was a wrong assumption on enabling these tests because we thought that a cluster wasn't really needed to successfully test and only a project, app, function and service was needed. This is not the case hence these tests are failing "the day after" these tests are set-up: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/6779817220/job/18429704811

While the right thing is to create the proper infra before testing it, I am just removing these tests for now to avoid acceptance tests to be red. Then will work on it properly with time.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@marcosuma marcosuma requested a review from a team as a code owner November 7, 2023 06:33
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 17%
Summary 3% (272 / 10332)

@lantoli lantoli merged commit 71c5f8d into master Nov 7, 2023
24 checks passed
@lantoli lantoli deleted the disable-event-trigger-tests branch November 7, 2023 06:49
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we create a ticket to fix the tests and introduce it again to the action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants