Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update PR action to automatically add labels based on the PR title #1637

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Nov 17, 2023

Description

Context

We use labels on PRs during the creation of the CHANGELOG: a PR is listed under a specific section of the changelog based on the label assigned to it.

Issue

We often forget to add the label to the PR which results in more time spent to manually update the CHANGELOG

Solution

This PR updates our PR linter to automatically add the correct label based on the Conventional Commits specification

FYI: I need to merge the changes to test that the action works as expected.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@andreaangiolillo andreaangiolillo changed the title feat: Update PR action to automatically add labels based on the PR title fet: Update PR action to automatically add labels based on the PR title Nov 17, 2023
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/testutils 46%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 17%
Summary 3% (284 / 10541)

@andreaangiolillo andreaangiolillo changed the title fet: Update PR action to automatically add labels based on the PR title feat: Update PR action to automatically add labels based on the PR title Nov 17, 2023
@andreaangiolillo andreaangiolillo marked this pull request as ready for review November 17, 2023 12:16
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner November 17, 2023 12:16
@marcosuma
Copy link
Collaborator

Nice!

Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not aware that the changelog generator used labels from PR, LGTM 👍

@andreaangiolillo andreaangiolillo merged commit 14fc004 into master Nov 17, 2023
30 of 32 checks passed
@andreaangiolillo andreaangiolillo deleted the add_auto_labels branch November 17, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants