Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary variables and use roles instead of keys for AWS Encryption-AtRest #441

Merged
merged 3 commits into from Apr 22, 2021

Conversation

nikhil-mongo
Copy link
Collaborator

remove unnecessary variables and use roles instead of keys for AWS Encryption-AtRest

Description

This improves the Encryption at Rest documentation and example cleanup. Fixes #424

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@nikhil-mongo
Copy link
Collaborator Author

Update the link

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but because the docs now link to the examples it would be great if you can create one for v0.9.0 (we are close to releasing) because it has a new way to do cloud provider access with one apply. Thanks!!

@themantissa themantissa merged commit 0b58372 into mongodb:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated usage example about "mongodbatlas_encryption_at_rest"
2 participants