Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary variables and use roles instead of keys for AWS Encryption-AtRest #441

Merged
merged 3 commits into from Apr 22, 2021
Merged

remove unnecessary variables and use roles instead of keys for AWS Encryption-AtRest #441

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
643e82c
remove unnecessary variables and use roles instead of keys for AWS En…
Apr 22, 2021
ae44ebf
doc update for encryption at rest resource
Apr 22, 2021
a529a02
update the link to example
Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/atlas-encryptionAtRest-roles-one-step-workaround/second_step/atlas-encryption.tf
View file
Open in desktop
Expand Up @@ -2,8 +2,6 @@ resource "mongodbatlas_encryption_at_rest" "test" {
project_id = var.project_id

aws_kms = {
access_key_id = var.access_key
secret_access_key = var.secret_key
enabled = true
customer_master_key_id = var.customer_master_key
region = var.atlas_region
Expand Down
8 changes: 0 additions & 8 deletions examples/atlas-encryptionAtRest-roles-one-step-workaround/second_step/variables.tf
View file
Open in desktop
Expand Up @@ -23,11 +23,3 @@ variable "cpa_role_id" {
description = "AWS IAM ROLE ARN"
default = ""
}
variable "access_key" {
description = "The access key for AWS Account"
default = ""
}
variable "secret_key" {
description = "The secret key for AWS Account"
default = ""
}
2 changes: 0 additions & 2 deletions examples/atlas-encryptionAtRest-roles-two-step/second_step/atlas-encryption.tf
View file
Open in desktop
Expand Up @@ -2,8 +2,6 @@ resource "mongodbatlas_encryption_at_rest" "test" {
project_id = var.project_id

aws_kms = {
access_key_id = var.access_key
secret_access_key = var.secret_key
enabled = true
customer_master_key_id = var.customer_master_key
region = var.atlas_region
Expand Down
8 changes: 0 additions & 8 deletions examples/atlas-encryptionAtRest-roles-two-step/second_step/variables.tf
View file
Open in desktop
Expand Up @@ -23,11 +23,3 @@ variable "cpa_role_id" {
description = "AWS IAM ROLE ARN"
default = ""
}
variable "access_key" {
description = "The access key for AWS Account"
default = ""
}
variable "secret_key" {
description = "The secret key for AWS Account"
default = ""
}
8 changes: 3 additions & 5 deletions website/docs/r/encryption_at_rest.html.markdown
View file
Open in desktop
Expand Up @@ -32,10 +32,9 @@ resource "mongodbatlas_encryption_at_rest" "test" {

aws_kms = {
enabled = true
access_key_id = "AKIAIOSFODNN7EXAMPLE"
secret_access_key = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"
customer_master_key_id = "030gce02-586d-48d2-a966-05ea954fde0g"
customer_master_key_id = "5ce83906-6563-46b7-8045-11c20e3a5766"
region = "US_EAST_1"
role_id = "60815e2fe01a49138a928ebb"
}

azure_key_vault = {
Expand Down Expand Up @@ -66,9 +65,8 @@ resource "mongodbatlas_encryption_at_rest" "test" {
* `google_cloud_kms` - (Required) Specifies GCP KMS configuration details and whether Encryption at Rest is enabled for an Atlas project.

### aws_kms
Refer to the example in the [official github repository](https://github.com/nikhil-mongo/terraform-provider-mongodbatlas/tree/master/examples) to implement Encryption at Rest
nikhil-mongo marked this conversation as resolved.
Show resolved Hide resolved
* `enabled` - Specifies whether Encryption at Rest is enabled for an Atlas project, To disable Encryption at Rest, pass only this parameter with a value of false, When you disable Encryption at Rest, Atlas also removes the configuration details.
* `access_key_id` - The IAM access key ID with permissions to access the customer master key specified by customerMasterKeyID.
* `secret_access_key` - The IAM secret access key with permissions to access the customer master key specified by customerMasterKeyID.
* `customer_master_key_id` - The AWS customer master key used to encrypt and decrypt the MongoDB master keys.
* `region` - The AWS region in which the AWS customer master key exists: CA_CENTRAL_1, US_EAST_1, US_EAST_2, US_WEST_1, US_WEST_2, SA_EAST_1
* `role_id` - ID of an AWS IAM role authorized to manage an AWS customer master key. To find the ID for an existing IAM role check the `role_id` attribute of the `mongodbatlas_cloud_provider_access` resource.
Expand Down