Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a github actions to automatically close stale issues/PRs based on CLOUDP-79100 #872

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 18, 2022

Description

This is a follow up of #843. This PR adds a cron job (https://github.com/marketplace/actions/close-stale-issues) that scans open issues/PRs and closes them based on the logic decided in CLOUDP-79100: Autoclose stale issues and PRs. We have recently enabled the same cron job for AtlasCLI (#1490) and atlas go client (#318)

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Comment on lines +261 to +262
- After 30 days of no activity (no comments or commits on an issue/PR) we automatically tag it as "stale" and add a message: ```This issue/PR has gone 30 days without any activity and meets the project's definition of "stale". This will be auto-closed if there is no new activity over the next 60 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!```
- After 60 more days of no activity we automatically close the issue/PR.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping this consistent with the CLI and go client https://github.com/mongodb/mongodb-atlas-cli/pull/1490/files

@andreaangiolillo andreaangiolillo marked this pull request as ready for review October 18, 2022 14:01
@themantissa
Copy link
Collaborator

Let me clean up a few issues before we merge this in. I should be able to do so before the end of the week. Once I do I will approve. @Zuhairahmed is this in line with the policy you wanted to implement.

Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is good github issue/PR hygiene and the 30/60 day clock is reasonable for now. we can always adjust cadence in future as needed. thanks again for automating this @andreaangiolillo! just FYI @martinstibbe

@themantissa
Copy link
Collaborator

@andreaangiolillo and @Zuhairahmed just to document it here. We are cleaning up a few last issues and then we'll institute this change. Once we are ready @Zuhairahmed let me know and I'll approve to unblock.

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zuhairahmed Zuhairahmed merged commit a86484d into master Nov 7, 2022
@Zuhairahmed Zuhairahmed deleted the INTMDB-395_github_actions branch November 7, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants