Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Travis tests to GitHub actions #93

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

cesarizu
Copy link
Contributor

@cesarizu cesarizu commented Aug 12, 2020

This PR converts Travis tests to GitHub actions. Currently all tests that pass in Travis are passing here as well. There are new tests using MongoDB 4.2.

Currently includes changes from: #92

@cesarizu cesarizu changed the title Converted travis tests to github actions Convert Travis tests to Github actions Aug 13, 2020
@cesarizu cesarizu changed the title Convert Travis tests to Github actions Convert Travis tests to GitHub actions Aug 13, 2020
@cesarizu
Copy link
Contributor Author

On the logs I see Could not find the type of CI for Danger to run on.. Seems that danger is outdated and newer versions support GitHub Actions. But mongoid-danger (from where this dependency comes from) hasn't been updated in 4 years.

@dblock
Copy link
Collaborator

dblock commented Aug 13, 2020

Let’s leave a Travis config that just runs Danger for now? We can deal with that one later.

This commit removes the TTL index as it would remove the whole document.
Also removes the unique index on the `locking_name` field as it is not
needed for the functionality of this gem.
@cesarizu cesarizu force-pushed the github-actions branch 2 times, most recently from 455510c to 39b6300 Compare August 26, 2020 16:09
@dblock
Copy link
Collaborator

dblock commented Aug 26, 2020

Can we put back a travis.yml that runs danger? We do want that for PR linting.

@mongoid-bot
Copy link

mongoid-bot commented Aug 26, 2020

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 danger

@cesarizu cesarizu force-pushed the github-actions branch 4 times, most recently from ca1e8b1 to 38832ec Compare August 26, 2020 16:43
@cesarizu
Copy link
Contributor Author

I added back a travis.yml that runs danger and updated the PR to include the fixes for mongoid 7 and the fix for mongodb 4 from #92.

@dblock dblock merged commit deca76c into mongoid:master Aug 26, 2020
@dblock
Copy link
Collaborator

dblock commented Aug 26, 2020

I merged this as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants