Mongoid 6 support #175
Closed
Mongoid 6 support #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Could you squash the commits. The @narutosanjiv could become only one commit and yours another one. |
| @@ -5,9 +5,20 @@ rvm: | |||
| - 2.1.8 | |||
| - 2.2.4 | |||
| - 2.3.0 | |||
| - 2.3.1 | |||
There was a problem hiding this comment.
here could be only 2.3.1 and remove 2.3.0
gurix
force-pushed
the
mongoid_6_support
branch
from
dcbbe30
to
09ccdbc
Compare
* Updated Readme * Setup test matrix for travis
gurix
force-pushed
the
mongoid_6_support
branch
from
09ccdbc
to
2162cbf
Compare
|
@rodrigopinto Changed everything according your suggestion. I hope the squashing is as you expected, I never did that before. |
|
Hi guys! |
|
I'm closing this PR as beta support of mongoid 6 is already in master. See #179 Also I don't think that HEAD of mongoid-rspec should support 2 versions of mongoid at time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Hey, I toke @narutosanjiv changes, updated the readme and implemented a proper test matrix for travis. Please don't hesitate to comment and I hope you accept this PR.