Make slug works fine with Mongoid::Paranoia

[sadjow]

The slug query is fiding the deleted document when using with Mongoid::Paranoia

[digitalplaywright]

Sorry for the delay. I'll look into this issue shortly.

[jhoffner]

This tricky issue just popped up for me as well. If you can point me in the right direction I can take a look.

[digitalplaywright]

@jhoffner Thank you for offering to take a look at this problem. The only file that needs changes is:

• https://github.com/digitalplaywright/mongoid-slug/blob/master/lib/mongoid/slug/criteria.rb

However, since Mongoid Paranoia is being moved out of Mongoid core in 4.0 the solution needs to work even if Mongoid Paranoia is not present. A solution might be to exclude documents that have the delete_at field set, since I believe Paranoid documents are marked using that field. Please let me know what you think.

[digitalplaywright]

@jhoffner The only method that needs to be changed is 'for_slugs(..)' and I think it is reasonable that Mongoid Slug is changed to never return any deleted documents.

[simi]

According to simi/mongoid_paranoia#1 (comment), feel free to add test cases to test project. I made some basic specs and it works.

[digitalplaywright]

@simi Sorry for not checking this better. I should have done a better job here. I can not at this point reproduce test-cases where Mongoid Slug fails with Mongoid Paranoia.

@jhoffner @sadjow I've added the test cases from @simi to Mongoid Slug master. Could you please either

• describe in detail the use-cases where Mongoid Slug return paranoid deleted documents? Which version of Mongoid and Mongoid Slug are you using?
• provide failing specs. See current passing Mongoid Paranoia specs at the bottom of https://github.com/digitalplaywright/mongoid-slug/blob/master/spec/mongoid/slug_spec.rb.

[digitalplaywright]

@jhoffner @sadjow I am closing this issue for now since we can not reproduce the problem. We will reopen this issue in the future if this changes. Please let us know if you are still experiencing this issue.