Removing todos

mongoid · May 27, 2012 · 2f366ea · 2f366ea
1 parent 0c8d4d3
commit 2f366ea
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 28 deletions.
diff --git a/lib/mongoid/atomic.rb b/lib/mongoid/atomic.rb
@@ -262,9 +262,6 @@ def delayed_atomic_pulls
     # @example Get the atomic paths.
     #   document.atomic_paths
     #
-    # @todo: Durran: Should probably raise error for embedded docs w/o
-    #   metadata.
-    #
     # @return [ Object ] The associated path.
     #
     # @since 2.1.0

diff --git a/lib/mongoid/config.rb b/lib/mongoid/config.rb
@@ -73,8 +73,6 @@ def connect_to(name)
 
     # Purge all data in all collections, including indexes.
     #
-    # @todo Durran: clean up.
-    #
     # @example Purge all data.
     #   Mongoid::Config.purge!
     #

diff --git a/lib/mongoid/contextual/mongo.rb b/lib/mongoid/contextual/mongo.rb
@@ -378,8 +378,6 @@ def apply_limit
 
       # Map the sort symbols to the correct MongoDB values.
       #
-      # @todo: Durran: Temporary.
-      #
       # @example Apply the sorting params.
       #   context.apply_sorting
       #
@@ -392,8 +390,6 @@ def apply_sorting
 
       # Map the inverse sort symbols to the correct MongoDB values.
       #
-      # @todo: Durran: Temporary.
-      #
       # @example Apply the inverse sorting params.
       #   context.apply_inverse_sorting
       #

diff --git a/lib/mongoid/dirty.rb b/lib/mongoid/dirty.rb
@@ -127,38 +127,29 @@ def remove_change(name)
     # Gets all the new values for each of the changed fields, to be passed to
     # a MongoDB $set modifier.
     #
-    # @todo: Durran: Refactor 3.0
-    #
     # @example Get the setters for the atomic updates.
     #   person = Person.new(:title => "Sir")
     #   person.title = "Madam"
     #   person.setters # returns { "title" => "Madam" }
     #
     # @return [ Hash ] A +Hash+ of atomic setters.
+    #
+    # @since 2.0.0
     def setters
-      modifications = {}
+      mods = {}
       changes.each_pair do |name, changes|
         if changes
           old, new = changes
           field = fields[name]
           key = atomic_attribute_name(name)
           if field && field.resizable?
-            field.add_atomic_changes(
-              self,
-              name,
-              key,
-              modifications,
-              new,
-              old
-            )
+            field.add_atomic_changes(self, name, key, mods, new, old)
           else
-            unless atomic_unsets.include?(key)
-              modifications[key] = new
-            end
+            mods[key] = new unless atomic_unsets.include?(key)
           end
         end
       end
-      modifications
+      mods
     end
 
     private

diff --git a/lib/mongoid/relations/nested_builder.rb b/lib/mongoid/relations/nested_builder.rb
@@ -57,8 +57,6 @@ def update_only?
 
       # Convert an id to its appropriate type.
       #
-      # @todo Durran: Move this into a common reusable place.
-      #
       # @example Convert the id.
       #   builder.convert_id(Person, "4d371b444835d98b8b000010")
       #

diff --git a/lib/mongoid/relations/synchronization.rb b/lib/mongoid/relations/synchronization.rb
@@ -36,8 +36,6 @@ def synced
 
       # Has the document been synced for the foreign key?
       #
-      # @todo Change the sync to be key based.
-      #
       # @example Has the document been synced?
       #   document.synced?
       #