Merge pull request mongodb#3890 from Shwetakale/set_feature

refs #3889 #3888 checks added for :set for dynamic attributes and error
on non-existing field.

CHANGELOG.md

@@ -3,6 +3,14 @@
 For instructions on upgrading to newer versions, visit
 [mongoid.org](http://mongoid.org/en/mongoid/docs/upgrading.html).
 
+## 4.0.2 - Not released
+
+### Resolved Issues
+
+* \#3888 raise UnknownAttributeError when 'set' is called on non existing field and Mongoid::Attributes::Dynamic is not included in model. (Shweta Kale)
+
+* \#3889 'set' will allow to set value of non existing field when Mongoid::Attributes::Dynamic is included in model. (Shweta Kale)
+
 ## 4.0.1
 
 ### Resolved Issues

lib/mongoid/persistable/settable.rb

@@ -22,7 +22,7 @@ module Settable
       def set(setters)
         prepare_atomic_operation do |ops|
           process_atomic_operations(setters) do |field, value|
-            send("#{field}=", value)
+            process_attribute(field.to_s, value)
             ops[atomic_attribute_name(field)] = attributes[field]
           end
           { "$set" => ops }

spec/mongoid/persistable/settable_spec.rb

@@ -136,4 +136,27 @@
       end
     end
   end
+
+  context "when dynamic attributes are not enabled" do
+    let(:account) do
+      Account.create
+    end
+
+    it "raises exception for an unknown attribute " do
+      expect {
+        account.set(somethingnew: "somethingnew")
+      }.to raise_error(Mongoid::Errors::UnknownAttribute)
+    end
+  end
+
+  context "when dynamic attributes enabled" do
+    let(:person) do
+      Person.create
+    end
+
+    it "updates non existing attribute" do
+      person.set(somethingnew: "somethingnew")
+      expect(person.reload.somethingnew).to eq "somethingnew"
+    end
+  end
 end