Skip to content

Commit

Permalink
resolves Ruby 2.2 warnings
Browse files Browse the repository at this point in the history
deletes duplicate key/value
fixes circular argument warning
  • Loading branch information
tonyta committed Mar 21, 2015
1 parent f00e43f commit 545713b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion lib/mongoid/persistence/atomic/operation.rb
Expand Up @@ -71,7 +71,7 @@ def operation(modifier)
# @return [ String, Symbol ] The path to the field.
#
# @since 2.1.0
def path(field = field)
def path(field = self.field)
position = document.atomic_position
position.blank? ? field : "#{position}.#{field}"
end
Expand Down
15 changes: 5 additions & 10 deletions spec/mongoid/atomic/positionable_spec.rb
Expand Up @@ -15,8 +15,7 @@
"$set" => {
"field" => "value",
"children.0.field" => "value",
"children.0.children.1.children.3.field" => "value",
"children.0.children.1.children.3.field" => "value",
"children.0.children.1.children.3.field" => "value"
},
"$pushAll" => {
"children.0.children.1.children.3.fields" => [ "value", "value" ]
Expand Down Expand Up @@ -113,8 +112,7 @@
"$set" => {
"field" => "value",
"children.$.field" => "value",
"children.$.children.1.children.3.field" => "value",
"children.$.children.1.children.3.field" => "value",
"children.$.children.1.children.3.field" => "value"
},
"$pushAll" => {
"children.$.children.1.children.3.fields" => [ "value", "value" ]
Expand Down Expand Up @@ -142,8 +140,7 @@
"$set" => {
"field" => "value",
"children.0.field" => "value",
"children.0.children.1.children.3.field" => "value",
"children.0.children.1.children.3.field" => "value",
"children.0.children.1.children.3.field" => "value"
},
"$pushAll" => {
"children.0.children.1.children.3.fields" => [ "value", "value" ]
Expand Down Expand Up @@ -172,8 +169,7 @@
"$set" => {
"field" => "value",
"children.$.field" => "value",
"children.0.children.$.children.3.field" => "value",
"children.0.children.$.children.3.field" => "value",
"children.0.children.$.children.3.field" => "value"
},
"$pushAll" => {
"children.0.children.$.children.3.fields" => [ "value", "value" ]
Expand Down Expand Up @@ -206,8 +202,7 @@
"$set" => {
"field" => "value",
"children.$.field" => "value",
"children.0.children.1.children.$.field" => "value",
"children.0.children.1.children.$.field" => "value",
"children.0.children.1.children.$.field" => "value"
},
"$pushAll" => {
"children.0.children.1.children.$.fields" => [ "value", "value" ]
Expand Down

0 comments on commit 545713b

Please sign in to comment.