Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

add timeout to address resolve #217

Merged
merged 1 commit into from Oct 2, 2013
Merged

add timeout to address resolve #217

merged 1 commit into from Oct 2, 2013

Conversation

arthurnn
Copy link
Contributor

I am not 100% sure, but I guess having a timeout on DNS resolve make sense. Also I had to stop using Socket.getaddrinfo in order to make the timeout block to work.

@durran Let me know if you see any problem with the solution.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.26%) when pulling cdf3438 on timeout_on_resolve into 1d96fc7 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.26%) when pulling 9737286 on timeout_on_resolve into 1d96fc7 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 9737286 on timeout_on_resolve into 1d96fc7 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 9737286 on timeout_on_resolve into 1d96fc7 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) when pulling 45644d9 on timeout_on_resolve into 0c6c261 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 45644d9 on timeout_on_resolve into 0c6c261 on master.

durran added a commit that referenced this pull request Oct 2, 2013
@durran durran merged commit 4d8d50b into master Oct 2, 2013
@arthurnn arthurnn deleted the timeout_on_resolve branch October 2, 2013 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants