Float.to_mongo(nil) should yield nil unless there's a good reason not…

… to. (e.g. latitude and longitude values of 0,0 actually means something.)
mongomapper · May 7, 2010 · 2be3cda · 2be3cda
1 parent a721b66
commit 2be3cda
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/mongo_mapper/support.rb b/lib/mongo_mapper/support.rb
@@ -61,7 +61,7 @@ def self.from_mongo(value)
 
 class Float
   def self.to_mongo(value)
-    value.to_f
+    value.nil? ? nil : value.to_f
   end
 end
 

diff --git a/test/unit/test_support.rb b/test/unit/test_support.rb
@@ -133,6 +133,10 @@ class SupportTest < Test::Unit::TestCase
         Float.to_mongo(value).should == 21.0
       end
     end
+
+    should "leave nil values nil" do
+      Float.to_mongo(nil).should == nil
+    end
   end
 
   context "Hash#from_mongo" do