Blank string now returns nil for ObjectId#to_mongo. Makes using it wi…

…th <select> tags and blank options easier. Fixes #140.
mongomapper · Dec 31, 2009 · a2474f2 · a2474f2
1 parent 63c0c7f
commit a2474f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/mongo_mapper/support.rb b/lib/mongo_mapper/support.rb
@@ -120,7 +120,7 @@ def self.from_mongo(value)
 
 class ObjectId
   def self.to_mongo(value)
-    if value.nil?
+    if value.blank?
       nil
     elsif value.is_a?(Mongo::ObjectID)
       value
@@ -165,7 +165,7 @@ def asc;  MongoMapper::OrderOperator.new(self, 'asc') end
   def desc; MongoMapper::OrderOperator.new(self, 'desc') end
 end
 
-class Time  
+class Time
   def self.to_mongo(value)
     if value.nil? || value == ''
       nil

diff --git a/test/unit/test_support.rb b/test/unit/test_support.rb
@@ -167,6 +167,10 @@ class SupportTest < Test::Unit::TestCase
       ObjectId.to_mongo(nil).should be_nil
     end
 
+    should "return nil if blank string" do
+      ObjectId.to_mongo('').should be_nil
+    end
+
     should "return value if object id" do
       id = Mongo::ObjectID.new
       ObjectId.to_mongo(id).should be(id)