Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dirty before callbacks #667

Merged
merged 2 commits into from Jan 19, 2021
Merged

Update dirty before callbacks #667

merged 2 commits into from Jan 19, 2021

Commits on Nov 25, 2020

  1. Update dirty before callbacks 

    * ActiveRecord updates its changes/previous_changes before
  after_create/after_update callbacks
* However, MongoMapper does that after the callbacks, therefore the
  changes/previous_changes values don't match with equivalent code in
  ActiveRecord.
    @ujihisa
    ujihisa committed Nov 25, 2020
    Copy the full SHA
    eb2641f View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. Test after_save 

    * Also cover the case when some callbacks didn't get called
    @ujihisa
    ujihisa committed Nov 26, 2020
    Copy the full SHA
    ad9e819 View commit details
    Browse the repository at this point in the history