Update rspec for CI and development to 3.8.0+ #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It supresses ERB.new deprecation warnings. rspec/rspec-core@c1b5695
We many need to pass the last optional Hash to `.with()` as Hash literal.
a2ikm
commented
May 25, 2022
| @@ -71,7 +71,7 @@ class Address; end | |||
| 'development' => {'hosts' => ['127.0.0.1:27017'], 'database' => 'test', 'read' => 'primary'} | |||
| } | |||
| logger = double('logger') | |||
| Mongo::Client.should_receive(:new).with(['127.0.0.1:27017'], :logger => logger, :read => :primary, :database => 'test') | |||
| Mongo::Client.should_receive(:new).with(['127.0.0.1:27017'], { :logger => logger, :read => :primary, :database => 'test' }) | |||
There was a problem hiding this comment.
MongoMapper.connect(environment, options={})'s last argument is a positional argument, not a keyword arguments. So we have to expect it as so.
These changes are related to rspec/rspec-mocks#1394.
|
Hmmm, coveraged for each file are calculated correctly, but total coverage are not. Related? |
a2ikm
changed the title
|
Let me merge. It may be one-off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It supresses ERB.new deprecation warnings.
rspec/rspec-core@c1b5695
Please check the CI outputs for Ruby 3.0+.
https://github.com/mongomapper/mongomapper/runs/6594866261?check_suite_focus=true#step:6:9 (this is for Ruby 3.1).
Fixed #697