-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for mergeObjects operator #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR.
Please add multiple tests in test__mongomock to ensure there are no regressions in the future.
removed mergeobjects exception checking tests and added a single test__merge_objects under the aggregate tests |
Thanks, almost there. Please fix the remaining styling issues |
Codecov Report
@@ Coverage Diff @@
## develop #689 +/- ##
===========================================
- Coverage 95.45% 95.34% -0.11%
===========================================
Files 19 19
Lines 3605 3612 +7
===========================================
+ Hits 3441 3444 +3
- Misses 164 168 +4
Continue to review full report at Codecov.
|
Thanks @elbehery95 for the hard work! |
As per #642
The current implementation follows the operator as defined such that on all null an empty doc is returned, and the docs are merged using
dict.update
method