Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements, bug fixes and support markdown in activity comments #1145

Merged
merged 6 commits into from Apr 11, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Apr 11, 2018

This closes #1133 and #1109

Also addresses several bugs.

@codecov
Copy link

codecov bot commented Apr 11, 2018

Codecov Report

Merging #1145 into master will decrease coverage by 0.1%.
The diff coverage is 71.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #1145     +/-   ##
==========================================
- Coverage      38.9%   38.9%   -<.1%     
  Complexity       11      11             
==========================================
  Files           200     200             
  Lines          5256    5260      +4     
==========================================
  Hits           2041    2041             
- Misses         3215    3219      +4
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/DashboardController.php 11.8% <66.7%> (-4.4%) 0 <0> (ø)
app/Activity.php 83.4% <75%> (-0.8%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d48f5...f5c32ae. Read the comment docs.

@djaiss djaiss changed the title Improvements and bug fixes Improvements, bug fixes and support markdown in activity comments Apr 11, 2018
@djaiss djaiss merged commit b03ca6d into master Apr 11, 2018
@djaiss djaiss deleted the 2018-04-09-improvements branch April 11, 2018 15:37
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.8.2. Dashboard Contact Count
1 participant