Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set new activity types through the UI #1583

Merged
merged 30 commits into from
Jul 29, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Jul 19, 2018

This is the second part of #1556.

This PR adds the ability to define new activity types and activity type categories through the UI. It also fixes one or two bugs in the API for these new methods (introduced in #1556).

This will address #282

image

Remaining core tasks:

  • Add success/error messages
  • Highlight rows when mouse hover
  • Make sure API doc is still accurate
  • This feature should be for paid accounts on .com

Checklist

Before submitting the PR

  • Screenshots are included if the PR changes the UI.

Code-related tasks

  • Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

@djaiss
Copy link
Member Author

djaiss commented Jul 21, 2018

@asbiin is this error in CircleCI linked to your refactor on 2FA?

image

@djaiss djaiss changed the title Add ability to set new activity types through the UI [wip] Add ability to set new activity types through the UI Jul 23, 2018
@djaiss
Copy link
Member Author

djaiss commented Jul 23, 2018

@asbiin alright there is definitely a problem I think with the 2FA test.

@djaiss djaiss mentioned this pull request Jul 29, 2018
7 tasks
@djaiss djaiss merged commit e734c88 into master Jul 29, 2018
@djaiss djaiss deleted the 2018-07-12-activity-types-settings branch August 13, 2018 02:10
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants