feat: Conversations #1629
Merged
feat: Conversations #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onica into 2018-07-26-feat-conversations
Open
![sonarcloud[bot]](https://avatars.githubusercontent.com/in/12526?s=60&v=4){kind=small}
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the concept of conversations.
Right now we can log phone calls. It's useful, but it's limited. What if we could log every communication with a contact? Each communication is a conversation. A conversation has one or more messages. The idea is to let users record conversations made on social media (FB, Whatsapp,...), interactions through SMS, meeting notes, phone calls, email,...
All this presented in a nice and friendly way. That way, I can remember for instance that I've had a nice conversation with a good friend of mine at this date, and we've talked about X.
This will close #917
For this first iteration, we won't migrate existing phone calls and we'll keep the calls feature, otherwise it will break the mobile application
Technical discussion
This PR uses the notion of service, and especially the notion of single action classes. The idea is to have one class per action.
It's very useful as it will let us write less code at the end. By using a class separated from your model, we can have the logic at one place, and call this logic from both the API and the web version, without having to write the backend twice.
Checklist
Code-related tasks
If the code changes the SQL schema
vCardand.csvfiles.Other tasks
UNRELEASED.