Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pluralize activities profile subtitle #1701

Merged
merged 3 commits into from
Aug 15, 2018
Merged

fix: Pluralize activities profile subtitle #1701

merged 3 commits into from
Aug 15, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Aug 15, 2018

Fix recent activities report.

  • pluralize people.activities_profile_subtitle text
  • fix people.activities_profile_number_occurences: in english, 0 times is "plural" form (well, it whould never display "0 activities" here, but voilà)
  • Carbon::formatLocalized is not working, the LC locale must be installed in the system to work. We should never use it. I've created a new DateHelper::getFullMonthAndDate function to replace this.

@asbiin asbiin changed the title Pluralize activities profile subtitle fix: Pluralize activities profile subtitle Aug 15, 2018
@asbiin asbiin merged commit 944cd51 into master Aug 15, 2018
@asbiin asbiin deleted the fix/pluralize_activities_profile_subtitle branch August 15, 2018 11:01
djaiss
djaiss reviewed Aug 15, 2018
View reviewed changes
app/Helpers/DateHelper.php
* @param Carbon $date
* @return string
*/
public static function getFullMonthAndDate($date)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asbiin where is the test for this 😀 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #1705

@asbiin asbiin mentioned this pull request Aug 15, 2018
Merged
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asbiin @djaiss @MonicaBot