Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vcard services for import/export #1996

Merged
merged 45 commits into from
Nov 11, 2018
Merged

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Nov 3, 2018

No description provided.

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 1
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 4

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Remove the unused function parameter "$request". (more)

See all issues in SonarCloud

@asbiin asbiin changed the title feat: vcard services for import/export [wip] feat: vcard services for import/export Nov 7, 2018
@asbiin asbiin requested a review from djaiss November 7, 2018 21:21
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Lots and lots of work.

I've tested the import locally and it works. One of our user's huge file (40mb) still doesn't work though, even with this method.

app/Http/Middleware/CheckLimitations.php Outdated Show resolved Hide resolved
app/Services/VCard/ExportVCard.php Show resolved Hide resolved
app/Services/VCard/ImportVCard.php Outdated Show resolved Hide resolved
app/Services/VCard/ImportVCard.php Outdated Show resolved Hide resolved
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

@asbiin asbiin merged commit 6c8a8ea into master Nov 11, 2018
@asbiin asbiin deleted the feat/vcard-import-export-services branch November 11, 2018 15:24
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants