-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the concept of places #2169
Conversation
…to 2018-12-18-add-places
…to 2018-12-18-add-places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…to 2018-12-18-add-places
This pull request has been automatically locked since there |
This PR adds the concept of places.
Context
A place is a physical address.
Places will be used throughout the app to represent… a place. Currently we use Address for this, but it's not right.
An Address belongs to a Contact and represents the address of where the contact lives (or lived), or works, or whatever.
But what if we wanted to add location information for activities? We can't use Address for this - otherwise they will also appear in the Address tab of the contact, which is not something we would like.
Therefore we need a way to represent a place. Hence this PR.
What this PR does
This PR